Clippy fixes

attestation-ca/build.rs

@@ -4,6 +4,7 @@ const OPENSSL_DOC: &str = "https://github.com/kanidm/webauthn-rs/blob/master/Ope
 
 fn main() {
  // LibreSSL reports as OpenSSL v2 (which was skipped).
+ #[allow(clippy::unusual_byte_groupings)]
  if number() < 0x2_00_00_00_0 {
  println!(
  r#"

base64urlsafedata/src/common.rs

@@ -15,6 +15,12 @@ macro_rules! common_impls {
  }
  }
 
+ impl Default for $type {
+ fn default() -> Self {
+ Self::new()
+ }
+ }
+
  impl std::ops::Deref for $type {
  type Target = Vec<u8>;
 

tutorial/wasm/src/lib.rs

@@ -59,7 +59,7 @@ impl App {
  return AppState::Error("A username must be provided".to_string());
  }
 
- self.last_username = username.clone();
+ self.last_username.clone_from(&username);
 
  // The fetch is done in a future/promise.
  ctx.link().send_future(async {
@@ -226,7 +226,7 @@ impl App {
  return AppState::Error("A username must be provided".to_string());
  }
 
- self.last_username = username.clone();
+ self.last_username.clone_from(&username);
 
  // The fetch is done in a future/promise.
  ctx.link().send_future(async {

webauthn-authenticator-rs/src/ctap2/ctap21_cred.rs

@@ -50,6 +50,7 @@ where
  ) -> Result<CredentialManagementResponse, WebauthnCError>;
 
  /// Send a [CredSubCommand] using a provided `pin_uv_auth_token` session.
+ #[allow(dead_code)]
  async fn cred_mgmt_with_session(
  &mut self,
  sub_command: CredSubCommand,

webauthn-rs-core/build.rs

@@ -4,6 +4,7 @@ const OPENSSL_DOC: &str = "https://github.com/kanidm/webauthn-rs/blob/master/Ope
 
 fn main() {
  // LibreSSL reports as OpenSSL v2.
+ #[allow(clippy::unusual_byte_groupings)]
  if number() < 0x2_00_00_00_0 {
  println!(
  r#"

webauthn-rs-proto/src/options.rs

@@ -3,6 +3,7 @@
 
 use base64urlsafedata::Base64UrlSafeData;
 use serde::{Deserialize, Serialize};
+use std::fmt::Display;
 use std::{collections::BTreeMap, str::FromStr};
 
 /// Defines the User Authenticator Verification policy. This is documented
@@ -163,8 +164,14 @@ impl FromStr for AuthenticatorTransport {
  }
 }
 
-impl ToString for AuthenticatorTransport {
- fn to_string(&self) -> String {
+impl Display for AuthenticatorTransport {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ f.write_str(self.as_ref())
+ }
+}
+
+impl AsRef<str> for AuthenticatorTransport {
+ fn as_ref(&self) -> &'static str {
  use AuthenticatorTransport::*;
  match self {
  Usb => "usb",
@@ -175,7 +182,6 @@ impl ToString for AuthenticatorTransport {
  Hybrid => "hybrid",
  Unknown => "unknown",
  }
- .to_string()
  }
 }
 

webauthn-rs-proto/src/wasm.rs

@@ -3,6 +3,7 @@ use wasm_bindgen::prelude::*;
 
 #[wasm_bindgen]
 extern "C" {
+ /// Public Key Credential Extension
  pub type PublicKeyCredentialExt;
 
  #[wasm_bindgen(static_method_of = PublicKeyCredentialExt, js_class = "PublicKeyCredential", js_name = isConditionalMediationAvailable, catch)]