[minor] Prefer signal.NotifyContext to signal.Notify in kanx (#3180)

kanisterio · Oct 10, 2024 · 691adf3 · 691adf3
1 parent 000ec09
commit 691adf3
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/pkg/kanx/server.go b/pkg/kanx/server.go
@@ -199,14 +199,14 @@ func NewServer() *Server {
 }
 
 func (s *Server) Serve(ctx context.Context, addr string) error {
-	stopChan := make(chan os.Signal, 1)
-	signal.Notify(stopChan, syscall.SIGTERM, syscall.SIGINT)
+	ctx, can := signal.NotifyContext(ctx, syscall.SIGTERM, syscall.SIGINT)
+	defer can()
 	go func() {
-		select {
-		case sig := <-stopChan:
-			log.Info().Print("Gracefully stopping. Received Signal", field.M{"signal": sig})
-		case <-ctx.Done():
-			log.Info().Print("Gracefully stopping. Context canceled")
+		<-ctx.Done()
+		if err := ctx.Err(); err == context.Canceled {
+			log.Info().Print("Gracefully stopping. Parent context canceled")
+		} else {
+			log.Info().WithError(err).Print("Gracefully stopping.")
 		}
 		s.grpcs.GracefulStop()
 	}()