Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the installation command #3119

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

anishbista60
Copy link
Contributor

@anishbista60 anishbista60 commented Sep 14, 2024

Change Overview

Made some changes to installation in kanister new-docs

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

Test Plan

  • 💪 Manual Testing:
    • Navigated to the docs_new directory.
    • Installed necessary dependencies using npm install.
    • Installed VitePress with npm install vitepress
    • Ran the development server with npm run docs:dev and verified that the documentation site loaded successfully without errors and changes are being rendered properly.
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Anish Bista <anishbista053@gmail.com>
@anishbista60
Copy link
Contributor Author

@PrasadG193 would you mind to take a look here ?

@PrasadG193
Copy link
Contributor

Can you please share the test plan - how did you test and verified the changes? In this case, can you please attach a screenshot of the rendered page after your changes?

@anishbista60
Copy link
Contributor Author

Can you please share the test plan - how did you test and verified the changes? In this case, can you please attach a screenshot of the rendered page after your changes?

Screenshot from 2024-09-16 11-43-46

@PrasadG193
Copy link
Contributor

@anishbista60 I think I wasn't clear with my comment.
I meant how did you test and validate the documentation changes you have made in this PR. Did you build and docs and verified if the changes are rendered correctly on the built html page. Can you add a screenshot of that?

@anishbista60
Copy link
Contributor Author

anishbista60 commented Sep 16, 2024

@PrasadG193 Thankyou and sorry previously i was not able to get that. After testing it, looks fine in my local server.

Screenshot from 2024-09-16 12-54-24
Screenshot from 2024-09-16 12-54-49
Screenshot from 2024-09-16 12-55-28

@PrasadG193
Copy link
Contributor

Thank you, can you please update the Test plan section in the PR description with your testing details?

@anishbista60
Copy link
Contributor Author

anishbista60 commented Sep 17, 2024

@PrasadG193 Done.

Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this

@anishbista60
Copy link
Contributor Author

@PrasadG193 could you please merge it ?

@mergify mergify bot merged commit 64f1866 into kanisterio:master Oct 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustment in Installation command in kanister new-docs
3 participants