Add the spec.selector field in the time-logger deployment
#3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Bista <anishbista053@gmail.com>
anishbista60
changed the title
spec.selector filed in the time-logger deploymentspec.selector field in the time-logger deployment
|
@shuguet could you please take a look here ? |
|
Looks good, thanks for fixing this |
PrasadG193
approved these changes
Sep 16, 2024
|
@PrasadG193 do you have right to merge it ? |
|
mergify doesn't have enough permission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Added the
spec.selectorfield in the time-logger deployment example in kanister new deployment.Pull request type
Please check the type of change your PR introduces:
Issues
spec.selectorfield intime-loggerdeployment manifest example in kanister new documentation #3120Test Plan