Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kopia snapshot verify command builder helper #3141

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Add kopia snapshot verify command builder helper #3141

merged 3 commits into from
Sep 27, 2024

Conversation

redgoat650
Copy link
Contributor

Change Overview

Add helper for constructing a kopia snapshot verify command, with a unit test case.

Pull request type

Please check the type of change your PR introduces:

  • 🌻 Feature

Test Plan

  • ⚡ Unit test
go test -v -check.vv -check.f TestSnapshotCommands
OK: 1 passed
--- PASS: Test (0.00s)
PASS
ok      github.com/kanisterio/kanister/pkg/kopia/command        0.024s

pavannd1
pavannd1 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julio-lopez julio-lopez enabled auto-merge (squash) September 25, 2024 02:35
ankitjain235
ankitjain235 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julio-lopez julio-lopez merged commit dac52b2 into master Sep 27, 2024
17 of 19 checks passed
@julio-lopez julio-lopez deleted the snapshot-verify branch September 27, 2024 18:36
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@pavannd1 pavannd1 pavannd1 approved these changes

@r4rajat r4rajat Awaiting requested review from r4rajat

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redgoat650 @pavannd1 @ankitjain235 @julio-lopez