Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linter unparam for test files #3162

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Enable linter unparam for test files #3162

merged 2 commits into from
Oct 7, 2024

Conversation

anishbista60
Copy link
Contributor

Change Overview

  • Enable linter unparam for test files

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • Ran make golint
  • 💚 E2E

@anishbista60
Copy link
Contributor Author

anishbista60 commented Sep 27, 2024 •
edited
Loading

@julio-lopez @pavannd1 would you mind to look into it ?

viveksinghggits
viveksinghggits requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, left a question/concern.

pkg/kopia/cli/repository/storage/s3/s3_test.go Outdated Show resolved Hide resolved
@anishbista60
Enable linter unparam for test files
091a0c4 
Signed-off-by: Anish Bista <anishbista053@gmail.com>
@anishbista60
Copy link
Contributor Author

@viveksinghggits Thankyou. please check it .

@anishbista60
Copy link
Contributor Author

could you please run the test cases? and try to get it merge

@mergify mergify bot merged commit 003b6ad into kanisterio:master Oct 7, 2024
18 checks passed
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@hairyhum hairyhum Awaiting requested review from hairyhum

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anishbista60 @viveksinghggits