Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: remove FLAG for userbility #73

Merged
merged 2 commits into from
Feb 12, 2023
Merged

change: remove FLAG for userbility #73

merged 2 commits into from
Feb 12, 2023

Conversation

kannkyo
Copy link
Owner

@kannkyo kannkyo commented Feb 12, 2023

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@kannkyo kannkyo added the Add New feature or request label Feb 12, 2023
@kannkyo kannkyo self-assigned this Feb 12, 2023
@kannkyo kannkyo changed the title Fix flag interface change: remove FLAG for userbility Feb 12, 2023
@github-actions
Copy link
Contributor

flake8 results

    1 files  ±0  51 suites  ±0   0s ⏱️ ±0s
  88 tests ±0    1 ✔️ ±0  0 💤 ±0    87 ±0 
542 runs  ±0  12 ✔️ ±0  0 💤 ±0  530 ±0 

For more details on these failures, see this check.

Results for commit 4829c5b. ± Comparison against base commit 188a605.

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 58.09% // Head: 59.10% // Increases project coverage by +1.00% 🎉

Coverage data is based on head (4829c5b) compared to base (4adc3f4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4829c5b differs from pull request most recent head 2a87089. Consider uploading reports for the commit 2a87089 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   58.09%   59.10%   +1.00%     
==========================================
  Files          43       43              
  Lines        4200     4208       +8     
==========================================
+ Hits         2440     2487      +47     
+ Misses       1760     1721      -39     
Flag Coverage Δ
unittests 59.10% <100.00%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/nvd_api/__init__.py 100.00% <ø> (ø)
src/nvd_api/client.py 100.00% <100.00%> (ø)
...vulnerabilities_inner_cve_vendor_comments_inner.py 56.75% <0.00%> (+27.02%) ⬆️
.../cpe_oas_products_inner_cpe_deprecated_by_inner.py 60.00% <0.00%> (+27.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kannkyo kannkyo merged commit b3d798c into main Feb 12, 2023
@kannkyo kannkyo deleted the fix-flag-interface branch February 12, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant