Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce wait time #97

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Reduce wait time #97

merged 2 commits into from
Feb 24, 2023

Conversation

kannkyo
Copy link
Owner

@kannkyo kannkyo commented Feb 24, 2023

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@kannkyo kannkyo added the Fix Something isn't working label Feb 24, 2023
@kannkyo kannkyo self-assigned this Feb 24, 2023
@github-actions
Copy link
Contributor

flake8 results

  1 files  ±0  14 suites  ±0   0s ⏱️ ±0s
  1 tests ±0    1 ✔️ ±0  0 💤 ±0  0 ±0 
14 runs  ±0  14 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f8de1b4. ± Comparison against base commit de3c5ca.

@github-actions
Copy link
Contributor

pytest results

99 tests  +1   97 ✔️ +1   7m 15s ⏱️ + 1m 1s
  1 suites ±0     2 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit f8de1b4. ± Comparison against base commit de3c5ca.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
tests.test_sleep.TestGetCpes ‑ test_sleep
tests.test_sleep.TestGetCpes ‑ test_sleep_with_wait_time
tests.test_sleep.TestGetCpes ‑ test_sleep_without_wait_time

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 73.00% // Head: 73.05% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (f8de1b4) compared to base (de3c5ca).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   73.00%   73.05%   +0.05%     
==========================================
  Files          43       43              
  Lines        4264     4272       +8     
==========================================
+ Hits         3113     3121       +8     
  Misses       1151     1151              
Flag Coverage Δ
unittests 73.05% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/nvd_api/client.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kannkyo kannkyo merged commit 062a826 into main Feb 24, 2023
@kannkyo kannkyo deleted the feature-reduce-wait-time branch February 24, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant