Skip to content

Commit

Permalink
Tweak default sorting of agendas table & QP error
Browse files Browse the repository at this point in the history
The session-kind test expects the PVV Ministerraad to come after the
normal Ministerraad in a filtered agendas table. With this new
default filtering, we explicitly apply this ordering.

An agendaitem delete call was causing errors which might be related to
these Ember bugs:

- emberjs/ember.js#20051
- emberjs/ember.js#19971

Leaving out setting anchor to null in hope that it might fix it.
  • Loading branch information
sergiofenoll committed Apr 16, 2022
1 parent 7794afa commit 164047d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/pods/agenda/agendaitems/agendaitem/index/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default class IndexAgendaitemAgendaitemsAgendaController extends Controll
if (neighbouringItem) {
this.router.transitionTo('agenda.agendaitems.agendaitem', this.meeting.id, this.agenda.id, neighbouringItem.id);
} else {
this.router.transitionTo('agenda.agendaitems', this.meeting.id, this.agenda.id,{ queryParams: { anchor: null }});
this.router.transitionTo('agenda.agendaitems', this.meeting.id, this.agenda.id);
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/pods/agendas/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class AgendasController extends Controller {
@tracked filter = null;
@tracked page = 0;
@tracked size = 10;
@tracked sort = '-status,created-for.planned-start';
@tracked sort = '-status,created-for.planned-start,created-for.kind.label';

dateRegex = /^(?:\d{1,2}\/)??(?:\d{1,2}\/)?\d{4}$/;

Expand Down

0 comments on commit 164047d

Please sign in to comment.