KAS-4897: the great controllers reset #2278
Open
+184
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kanselarij.atlassian.net/browse/KAS-4897
In deze ticket ben ik door alle controllers in de app gegaan en waar mogelijk kleine issues met het resetten van de controllers rechtgezet. Het ging voornamelijk over kleine dingen zoals modals die open bleven staan en
thing = store.createRecord()die niet verwijderd worden.Dit laatste doen we ook in componenten en daar zouden we dat ook moeten opkuisen, maar dat is misschien voor een andere ticket.
De eigenlijke issue die in de ticket beschreven werd is in f120918 gefixt geweest met (zoals Sven al aangaf in de comments van de ticket) een
reload(). Eigenlijk is dat ook het enige dat écht gemerged "moet" worden.