Invert sense #39
Invert sense #39
Conversation
|
Just checking in on this, if you have any questions/issues. |
|
Haven't had a chance to test this yet. One thing I noticed that could be changed is the senseGPIOPinPUD drop down in the settings UI. I think it would be nicer to put it horizontally before or after the invert checkbox with no label. Change "Off" to "No Pull Up/Down" or something similar. Thoughts? |
|
I was concerned with the length of the drop down. I originally had it something along those lines. I figured the page was better suited to vertical than horizontal, but I'm up for anything. Let me know if you want me to modify the PR. |
|
As long as it sits in one line it should be fine. Thanks for the help! |
|
Alright I've finally tested the code changes. Looks good! 👍 If you prefer I can make the UI changes. Let me know. |
|
Might be faster if you do, I've run into a few setbacks on my side. Glad you like it, and thank you for all the work you've put into the plugin. |
|
Alright. Added to my TODO list. Thanks for your additions! |
|
Merged |
Add getPSUState API Command (#34) Set initial state of the switching GPIO accordingly (#40) Add Pseudo On/Off G-Code Switching (#26) Added M106 to autoOnTriggerGCodeCommands defaults (#45) Move static power off dialog from jinja2 template to js (#46) Change power off dialog message Add invert and pull-up/down options for Sensing (#39) Add support for sensing via system commands
Closes #36