Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept solutions to chips challenges regardless of case #1494

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

zmbc
Copy link
Contributor

@zmbc zmbc commented Aug 1, 2021

As mentioned here, requiring correct capitalization for chips challenge solutions is not intended. This change implements that, so that "como pan" is correct if there is an alternative solution "Como pan".

@vercel
Copy link

vercel bot commented Aug 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kantord/libre-lingo/2RjM5g2Twu5bTNFoSD2j9iP4UeQE
✅ Preview: https://libre-lingo-git-fork-zmbc-case-insensitive-chips-kantord.vercel.app

@zmbc zmbc changed the title Case insensitive chips challenges solutions fix: Accept solutions to chips challenges regardless of case Aug 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kantord
Copy link
Owner

kantord commented Aug 2, 2021

Amazing! 💯

thank you @zmbc

@kantord kantord merged commit 2050607 into kantord:main Aug 2, 2021
@kantord
Copy link
Owner

kantord commented Aug 2, 2021

🎉 This PR is included in version @librelingo/web-v1.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants