Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation in "new words" overwrites mini-dictionary #1715

Open
zmbc opened this issue Oct 18, 2021 · 1 comment
Open

Translation in "new words" overwrites mini-dictionary #1715

zmbc opened this issue Oct 18, 2021 · 1 comment

Comments

@zmbc
Copy link
Contributor

zmbc commented Oct 18, 2021

Describe the bug
When a word has a Translation in the New words array, no matter what you put in the Mini-dictionary, only the New words value will appear in the hint tooltip.

To Reproduce

skill yaml (excerpt)

New words:
  - Word: toki!
    Translation: Hello!
    Images:
      - hello1
      - hello2
      - hello3
...
Phrases:
  - Phrase: toki
    Translation: communicate
...
Mini-dictionary:
  toki pona:
    - toki:
      - communicate
      - hello

The resulting mini-dictionary entry is:

{
  "word": "toki",
  "definition": "Hello!"
}

Expected behavior
The resulting mini-dictionary entry should be:

{
  "word": "toki",
  "definition": "Hello!\ncommunicate\nhello"
}

Additional context
First reported in #1445, but I thought it should have its own issue for tracking.

@kantord
Copy link
Owner

kantord commented Oct 18, 2021

thanks @zmbc, it definitely deserves to have it's own issue indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants