Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No self use issue fix #1912

Merged
merged 6 commits into from
Dec 28, 2021
Merged

No self use issue fix #1912

merged 6 commits into from
Dec 28, 2021

Conversation

vil02
Copy link
Collaborator

@vil02 vil02 commented Dec 26, 2021

Description

Fixes issue #1902. I also replaced "naked" assert with self.assertEqual, self.assertIsInstance etc. in some of the tests.

Is this related to any open issue(s)?

fixes #1902

Is there anything you need help with to get this PR merged?

...

Checklist

Don't worry if you haven't done everything on this checklist. Simply create your PR, and make sure everything is done later,
or ask for help if you don't know how to do it.

  • The CI is passing
  • I tested my implementation manually
  • I wrote new tests to test my code, or updated existing tests to test my changes

@vercel
Copy link

vercel bot commented Dec 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kantord/libre-lingo/Bz9TFvHL55yejcwcV15cLgSakfgR
✅ Preview: https://libre-lingo-git-fork-vil02-no-self-useissuefix-kantord.vercel.app

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kantord
Copy link
Owner

kantord commented Dec 28, 2021

thanks @vil02 ! I'll try to check it out as soon as I have time.

@kantord
Copy link
Owner

kantord commented Dec 28, 2021

Looks good to me! Thanks @vil02 !

btw the best ideal solution would be to get rid of those test case classes completely and use proper pytest style.

Of course that needs not to be in the context if this merge request, hence I approve and merge this!

Nevertheless if you are looking for the next challenge, you could do that one!

@kantord kantord merged commit c6c8c7b into kantord:main Dec 28, 2021
@kantord
Copy link
Owner

kantord commented Dec 28, 2021

@allcontributors please add @vil02

@allcontributors
Copy link
Contributor

@kantord

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@kantord
Copy link
Owner

kantord commented Dec 28, 2021

@allcontributors please add @vil02 for code

@allcontributors
Copy link
Contributor

@kantord

I've put up a pull request to add @vil02! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylint config: enable "no-self-use"
2 participants