-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No self use issue fix #1912
No self use issue fix #1912
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kantord/libre-lingo/Bz9TFvHL55yejcwcV15cLgSakfgR |
Kudos, SonarCloud Quality Gate passed!
|
thanks @vil02 ! I'll try to check it out as soon as I have time. |
Looks good to me! Thanks @vil02 ! btw the best ideal solution would be to get rid of those test case classes completely and use proper pytest style. Of course that needs not to be in the context if this merge request, hence I approve and merge this! Nevertheless if you are looking for the next challenge, you could do that one! |
@allcontributors please add @vil02 |
I couldn't determine any contributions to add, did you specify any contributions? |
@allcontributors please add @vil02 for code |
I've put up a pull request to add @vil02! 🎉 |
Description
Fixes issue #1902. I also replaced "naked" assert with self.assertEqual, self.assertIsInstance etc. in some of the tests.
Is this related to any open issue(s)?
fixes #1902
Is there anything you need help with to get this PR merged?
...
Checklist
Don't worry if you haven't done everything on this checklist. Simply create your PR, and make sure everything is done later,
or ask for help if you don't know how to do it.