Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date package with isValidDate #16

Merged
merged 3 commits into from
Oct 1, 2022
Merged

Add date package with isValidDate #16

merged 3 commits into from
Oct 1, 2022

Conversation

kanziw
Copy link
Owner

@kanziw kanziw commented Oct 1, 2022

No description provided.

@kanziw kanziw self-assigned this Oct 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #16 (0d9ac31) into main (9ff7360) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines           83        86    +3     
  Branches         9        10    +1     
=========================================
+ Hits            83        86    +3     
Impacted Files Coverage Δ
packages/crypto/src/sha256.ts 100.00% <100.00%> (ø)
packages/date/src/isValidDate.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -10,7 +10,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.2
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarnpkg/berry#4778

node version issue로 인해 CI에서의 version을 pin합니다.

@kanziw kanziw merged commit f156bbf into main Oct 1, 2022
@kanziw kanziw deleted the add-date-package branch October 1, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants