Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when click pdf link will collapse itself if active #147

Closed
iampz opened this issue Mar 21, 2024 · 0 comments · Fixed by #148
Closed

Fix bug when click pdf link will collapse itself if active #147

iampz opened this issue Mar 21, 2024 · 0 comments · Fixed by #148
Assignees

Comments

@iampz
Copy link
Collaborator

iampz commented Mar 21, 2024

1, Stop propagation to not pass click down to parent accordion button
2. If it is active, not collapse itself
3. If it isn't active, collapse others and expand this one
4. Refactor utils/accordion.js variable name to be more readable

@iampz iampz self-assigned this Mar 21, 2024
@iampz iampz changed the title Fix bug when click pdf link make accordion toggle on section page Fix bug when click pdf link will collapse itself if active Mar 21, 2024
@iampz iampz linked a pull request Mar 21, 2024 that will close this issue
iampz added a commit that referenced this issue Mar 21, 2024
…will-collapse-itself-if-active

#147 fix bug when click pdf link will collapse itself if active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant