-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix emoji detection issue #120
Conversation
Co-authored-by: Phaiboon A <67526393+ExitedState@users.noreply.github.com>
thanks, this pr becomes much easier to review now.
|
…alter test to also test discrimination between number emoji and raw number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! all tests are passing now.
although there are rooms for improvement, every reviewed issue is contained within one file, which makes them easy to improve.
gonna merge this in for now and make it better later.
Description
fix #108
Type of change
Screenshot
Checklist:
pnpm format
and my code don't have any linting issues