Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix emoji detection issue #120

Merged
merged 8 commits into from
May 23, 2023
Merged

Conversation

01110111-wave
Copy link
Contributor

@01110111-wave 01110111-wave commented May 23, 2023

Description

fix #108

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshot

image

Checklist:

  • I have run pnpm format and my code don't have any linting issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

src/utils/isOnlyEmoji.ts Outdated Show resolved Hide resolved
src/utils/isOnlyEmoji.ts Outdated Show resolved Hide resolved
src/utils/isOnlyEmoji.ts Outdated Show resolved Hide resolved
01110111-wave and others added 3 commits May 23, 2023 19:26
@dtinth
Copy link
Collaborator

dtinth commented May 23, 2023

thanks, this pr becomes much easier to review now.

Copy link
Collaborator

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! all tests are passing now.

although there are rooms for improvement, every reviewed issue is contained within one file, which makes them easy to improve.

gonna merge this in for now and make it better later.

@dtinth dtinth added this pull request to the merge queue May 23, 2023
Merged via the queue into kaogeek:main with commit 47c35d2 May 23, 2023
@01110111-wave 01110111-wave deleted the fix-emoji-detection branch May 24, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix isOnlyEmoji so that numbers are not considered emoji
4 participants