Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix feature : update isOnlyEmoji #128

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

ExitedState
Copy link
Contributor

@ExitedState ExitedState commented May 24, 2023

Description

reopen from #127 due to a low quality commit msg

  1. updated isOnlyEmoji now also checks for the Combining Enclosing Keycap (0x20E3), which is another way to create keycap number emojis (like 1️⃣, 2️⃣, 3️⃣, etc)
    • we can test it by copying a string from isOnlyEmoji.spec.ts at line 23
  2. refactor the function for more readability.
  3. add more test case

//emoji behaviour is so weird

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor or other

Screenshot

image

Checklist:

  • I have run pnpm format and my code don't have any linting issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@leomotors leomotors requested a review from dtinth May 24, 2023 09:36
Copy link
Collaborator

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, i appreciate the added tests and comments

@@ -1,30 +1,47 @@
import { describe, expect, it } from 'vitest'

import isOnlyEmoji from './isOnlyEmoji.js'
// import isOnlyEmojiV1 from './isOnlyEmoji'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳

@dtinth dtinth added this pull request to the merge queue May 24, 2023
Merged via the queue into kaogeek:main with commit 9851fbc May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants