-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a embed style for all command. #35
Conversation
Can we separate the embed template creation to another function accepting required information?
|
yap, it can be done Ex: template of image command cosnt ImageEmbed = (url: string, description: string) => ({
description,
image: { url },
}) Ex: usage await channel.send({
embeds: [ImageEmbed("https://i.imgur.com/...", "This is a cat")],
}); but actually the |
please add some screenshot so we see the end result krubb 🙏 |
* Beautify bot reply using embed * revert report embed for #35
meanwhile, i just merged #37 because the implementation is simple and PR is very small scope and the PR author also provided a screenshot. but there are other valid improvements in this PR, please rebase krub 🙏 |
My purpose is not for reusability for this matter, it is more toward readability and testing (in the future). |
README.md
Outdated
cp .env.example .env | ||
|
||
# Change node version to 16 | ||
nvm install v16 # if you don't have node 16 installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project actually use node 18, you might want to change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, in package.json, it specifies both v16 and v18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yap v16 and v18, but i'm use v19 is default.
I and someone must change node version to develop.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to nvm use
. It will auto detect the version in .nvmrc
I will try. Thank you. |
src/client.ts
Outdated
) | ||
const commandFolders = globSync( | ||
path.resolve(this.__dirname, 'commands/**/*.{js,ts}'), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This revert #33 please change back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pnpm format
all done. maybe. |
Description
Added a embed style for the report command.
Changes