优化抛出异常的逻辑

kaokei · Jan 13, 2025 · 81b4d92 · 81b4d92
1 parent c2a280b
commit 81b4d92
Show file tree

Hide file tree

Showing 15 changed files with 32 additions and 84 deletions.
diff --git a/src/binding.ts b/src/binding.ts
@@ -8,7 +8,7 @@ import {
 import { Container } from './container';
 import { getMetadata, getOwnMetadata } from './cachemap';
 import { resolveToken } from './token';
-import { CircularDependencyError } from './errors';
+import { CircularDependencyError, BindingNotValidError } from './errors';
 
 export class Binding {
   public container!: Container;
@@ -108,7 +108,7 @@ export class Binding {
     } else if (BindingTypeEnum.DynamicValue === this.type) {
       return this.resolveDynamicValue();
     } else {
-      //  throw error
+      throw new BindingNotValidError(this);
     }
   }
 

diff --git a/src/container.ts b/src/container.ts
@@ -1,5 +1,5 @@
 import { Binding } from './binding';
-import { TokenNotFoundError } from './errors/TokenNotFoundError';
+import { TokenNotFoundError, DuplicateBindingError } from './errors';
 import { IDENTITY, NOOP } from './constants';
 import { GenericToken } from './interfaces';
 
@@ -11,7 +11,7 @@ export class Container {
 
   public bind(serviceIdentifier: any) {
     if (this.bindings.has(serviceIdentifier)) {
-      // todo: throw new Error('Already bound');
+      throw new DuplicateBindingError(serviceIdentifier);
     }
     const binding = this.buildBinding(serviceIdentifier);
     this.bindings.set(serviceIdentifier, binding);

diff --git a/src/errors/BindingNotValidError.ts b/src/errors/BindingNotValidError.ts
@@ -0,0 +1,10 @@
+export class BindingNotValidError extends Error {
+  public name = 'BINDING_NOT_VALID_ERROR';
+  public message = this.name;
+
+  constructor(binding: any) {
+    super();
+
+    this.message = `BINDING NOT VALID. YOU CAN USE ONE OF THESE METHODS {to/toSelf/toService/toConstantValue/toDynamicValue}. ${binding}`;
+  }
+}
diff --git a/src/errors/ConstructorInjectMissTokenError.ts b/src/errors/ConstructorInjectMissTokenError.ts
diff --git a/src/errors/DuplicateBindingError.ts b/src/errors/DuplicateBindingError.ts
@@ -0,0 +1,10 @@
+export class DuplicateBindingError extends Error {
+  public name = 'DUPLICATE_BINDING_ERROR';
+  public message = this.name;
+
+  constructor(token: any) {
+    super();
+
+    this.message = `DUPLICATE BINDING. ${token}`;
+  }
+}
diff --git a/src/errors/InjectFailedError.ts b/src/errors/InjectFailedError.ts
diff --git a/src/errors/PropertyInjectMissTokenError.ts b/src/errors/PropertyInjectMissTokenError.ts
diff --git a/src/errors/ProviderNotValidError.ts b/src/errors/ProviderNotValidError.ts
diff --git a/src/errors/TokenNotFoundError.ts b/src/errors/TokenNotFoundError.ts
@@ -5,6 +5,6 @@ export class TokenNotFoundError extends Error {
   constructor(token: any) {
     super();
 
-    this.message = `TOKEN IS NOT A INJECTABLE CLASS OR SKIP OUT OF ROOT INJECTOR. YOU CAN USE @Optional DECORATOR TO IGNORE THIS ERROR IF THIS SERVICE IS OPTIONAL. ${token}`;
+    this.message = `TOKEN IS NOT BOUND TO CONTAINER. YOU CAN USE @Optional DECORATOR TO IGNORE THIS ERROR IF THIS SERVICE IS OPTIONAL. ${token}`;
   }
 }
diff --git a/src/errors/index.ts b/src/errors/index.ts
@@ -1,6 +1,4 @@
-export { CircularDependencyError } from './CircularDependencyError';
-export { InjectFailedError } from './InjectFailedError';
-export { ProviderNotValidError } from './ProviderNotValidError';
 export { TokenNotFoundError } from './TokenNotFoundError';
-export { ConstructorInjectMissTokenError } from './ConstructorInjectMissTokenError';
-export { PropertyInjectMissTokenError } from './PropertyInjectMissTokenError';
+export { BindingNotValidError } from './BindingNotValidError';
+export { DuplicateBindingError } from './DuplicateBindingError';
+export { CircularDependencyError } from './CircularDependencyError';
diff --git a/src/test.ts b/src/test.ts
diff --git a/tsconfig.app.json b/tsconfig.app.json
@@ -20,7 +20,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
-    "noUncheckedSideEffectImports": true
+    // "noUncheckedSideEffectImports": true
   },
   "include": ["src/**/*.ts"],
   "exclude": ["src/**/*.ignore.ts"]

diff --git a/tsconfig.node.json b/tsconfig.node.json
@@ -18,7 +18,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
-    "noUncheckedSideEffectImports": true
+    // "noUncheckedSideEffectImports": true
   },
   "include": ["vite.config.ts"]
 }
diff --git a/tsconfig.vitest.json b/tsconfig.vitest.json
@@ -26,7 +26,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
-    "noUncheckedSideEffectImports": true
+    // "noUncheckedSideEffectImports": true
   },
   "include": ["tests/**/*.ts"]
 }
diff --git a/vite.config.ts b/vite.config.ts
@@ -13,7 +13,7 @@ import dts from 'vite-plugin-dts';
 export default defineConfig({
   plugins: [
     dts({
-      rollupTypes: true,
+      // rollupTypes: true,
       include: ["./src"],
       tsconfigPath: './tsconfig.app.json',
       beforeWriteFile: (filePath, content) => {