Add pointer to pantsbuild#15824 for broken tests.

[ci skip-rust] [ci skip-build-wheels]
kaos · Jun 14, 2022 · 23866e2 · 23866e2
1 parent bbe1182
commit 23866e2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/python/pants/backend/go/util_rules/third_party_pkg_test.py b/src/python/pants/backend/go/util_rules/third_party_pkg_test.py
@@ -264,7 +264,7 @@ def test_invalid_go_sum(rule_runner: RuleRunner) -> None:
         rule_runner.request(AllThirdPartyPackages, [AllThirdPartyPackagesRequest(digest, "go.mod")])
 
 
-@pytest.mark.skip("broken test")
+@pytest.mark.skip(reason="TODO(#15824)")
 def test_missing_go_sum(rule_runner: RuleRunner) -> None:
     digest = set_up_go_mod(
         rule_runner,
@@ -285,10 +285,9 @@ def test_missing_go_sum(rule_runner: RuleRunner) -> None:
     )
     with engine_error(contains="github.com/google/uuid@v1.3.0: missing go.sum entry"):
         rule_runner.request(AllThirdPartyPackages, [AllThirdPartyPackagesRequest(digest, "go.mod")])
-        assert False, "should not get here!"
 
 
-@pytest.mark.skip("broken test")
+@pytest.mark.skip(reason="TODO(#15824)")
 def test_stale_go_mod(rule_runner: RuleRunner) -> None:
     digest = set_up_go_mod(
         rule_runner,
@@ -312,7 +311,6 @@ def test_stale_go_mod(rule_runner: RuleRunner) -> None:
     )
     with engine_error(ProcessExecutionFailure, contains="updates to go.mod needed"):
         rule_runner.request(AllThirdPartyPackages, [AllThirdPartyPackagesRequest(digest, "go.mod")])
-        assert False, "should not get here!"
 
 
 def test_pkg_missing(rule_runner: RuleRunner) -> None:

diff --git a/src/python/pants/backend/python/util_rules/pex_from_targets_test.py b/src/python/pants/backend/python/util_rules/pex_from_targets_test.py
@@ -69,7 +69,7 @@ def rule_runner() -> RuleRunner:
     )
 
 
-@pytest.mark.skip("broken test")
+@pytest.mark.skip(reason="TODO(#15824)")
 def test_choose_compatible_resolve(rule_runner: RuleRunner) -> None:
     def create_target_files(
         directory: str, *, req_resolve: str, source_resolve: str, test_resolve: str

diff --git a/src/python/pants/jvm/resolve/coursier_fetch_integration_test.py b/src/python/pants/jvm/resolve/coursier_fetch_integration_test.py
@@ -155,7 +155,7 @@ def test_resolve_with_inexact_coord(rule_runner: RuleRunner) -> None:
     )
 
 
-@pytest.mark.skip("broken test")
+@pytest.mark.skip(reason="TODO(#15824)")
 @maybe_skip_jdk_test
 def test_resolve_conflicting(rule_runner: RuleRunner) -> None:
     with engine_error(