Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GltfProcessed marker to objects #144

Closed
janhohenheim opened this issue Feb 22, 2024 · 1 comment · Fixed by #136
Closed

Add a GltfProcessed marker to objects #144

janhohenheim opened this issue Feb 22, 2024 · 1 comment · Fixed by #136

Comments

@janhohenheim
Copy link
Contributor

As we discussed in Discord, we currently iterate over all Gltf models on every frame. If we add a GltfProcessed marker to the objects after reading their GltfExtras, we can constrain the query with a Without<GltfProcessed>, which is an archetype and thus makes the query not need to loop over everything.
@kaosat-dev
Copy link
Owner

Agreed ! That is a pattern I often use already to restrict the queries, good fit, simple, efficient.

@kaosat-dev kaosat-dev mentioned this issue Feb 26, 2024
Merged
kaosat-dev added a commit that referenced this issue Mar 4, 2024
@kaosat-dev @janhohenheim
chore(Bevy): Update to bevy 0.13 (#136)
09915f5 
* chore(crates): updated crates to Bevy 0.13
   * updated deps
   * updated / changed code where relevant
   * updated README files
   * bumped version numbers for upcoming release
   * updated rust-toolchain
   * updated assets where relevant
   * closes #132 
* feat(bevy_gltf_components): 
  * added GltfProcessed flag component to improve performance of iteration over added<gltfExtras>
  * closes #144 
  * light & shadow processing is now integrated,  to match  lights coming from Blender: you can now control whether 
  lights cast shadows, the cascade resolution , background color etc  from Blender
   * closes #155 

* feat(bevy_registry_export): added boilerplate to make registry path relative to assets folder 
  * closes #137 
* feat(tools): added boilerplate for internal tools
   * clean zip file generator for blender add-on releases
   * example gltf file generator
* feat(lighting): added components, exporter support & testing for blender-configurable shadows
   * added BlenderLightShadows component to bevy_gltf_components
   * added writing shadow information to gltf_auto_export
   * updated tests
   * closes #157 

Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(Bevy): Update to bevy 0.13 kaosat-dev/Blenvy
2 participants
@kaosat-dev @janhohenheim