Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add tokenize property to Sort step #667

Merged
merged 1 commit into from
May 25, 2023

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented May 19, 2023

The sort step should have an additional property - tokenize

Based on the documentation - https://camel.apache.org/components/3.20.x/eips/sort-eip.html#_using_sort_eip

@tplevko tplevko requested a review from a team May 19, 2023 10:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Delawen
Copy link
Collaborator

Delawen commented May 19, 2023

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #667 (0404a2e) into main (5fe92c1) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #667      +/-   ##
============================================
- Coverage     79.28%   79.02%   -0.27%     
  Complexity      148      148              
============================================
  Files            48       48              
  Lines          2660     2660              
  Branches        416      416              
============================================
- Hits           2109     2102       -7     
- Misses          369      375       +6     
- Partials        182      183       +1     

see 2 files with indirect coverage changes

@tplevko
Copy link
Contributor Author

tplevko commented May 19, 2023

Sure, added kaoto-archive/camel-component-metadata#19
Thanks for the reminder @Delawen

@Delawen Delawen enabled auto-merge (rebase) May 24, 2023 10:42
@Delawen
Copy link
Collaborator

Delawen commented May 24, 2023

Windows Github machines are the worst! Sorry, @tplevko it is taking longer than expected.

@tplevko
Copy link
Contributor Author

tplevko commented May 25, 2023

@Delawen is this good for merge, or should I add additional tests? the codeconv seems to complain :/

@Delawen
Copy link
Collaborator

Delawen commented May 25, 2023

It is good once it passes on Windows. I don't like to merge without that passing... just in case. Doesn't seem to be your problem, though.

@Delawen Delawen merged commit 4b62771 into kaoto-archive:main May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants