Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Quarkus3 upgrade #695

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Quarkus3 upgrade #695

merged 10 commits into from
Jun 21, 2023

Conversation

mkralik3
Copy link
Contributor

@mkralik3 mkralik3 commented Jun 13, 2023

Continue of #645
This PR contains:

  • Kaoto-backend was upgraded to the latest Quarkus3 version (3.1.2)
  • quarkus-universe-bom was changed to quarkus-bom because it is deprecated.
  • kubernetes-client.devservices was disabled (which comes from quarkus-kubernetes-client and it is enabled by default) in tests where it is not used because it causes problems on Windows workflows due to uncatched exception from testcontainers package ( probable a bug, needs to be reported in Quarkus project )
  • Changed imports for OpenTelemetry (@SpanAttribute @WithSpan) since they were moved to a different package and the original ones have been marked as deprecated
  • Disabled OpenTelemetry by default since in Quarkus3 uses OpenTelemetry SDK Autoconfigure and expects OTLP exporter on localhost:4317 which causes SEVERE error in the log. Now, the users which wants to use kaoto-backend with some OTLP exporter (e.g. Jaeger), it can use quarkus config properties quarkus.otel.sdk.disabled=false and quarkus.otel.exporter.otlp.traces.endpoint=<OTLP gRPC receiver URL>
  • CORS origins configuration property with Kaoto-ui URL needs to be set in production. For dev mode, all origins are allowed ( wildcard origins: /.*/ )

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #695 (8786c94) into main (93105b8) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #695      +/-   ##
============================================
- Coverage     77.60%   77.46%   -0.15%     
+ Complexity      155      154       -1     
============================================
  Files            53       53              
  Lines          2831     2831              
  Branches        466      466              
============================================
- Hits           2197     2193       -4     
- Misses          453      457       +4     
  Partials        181      181              
Impacted Files Coverage Δ
.../backend/api/resource/v1/CapabilitiesResource.java 66.66% <ø> (ø)
.../backend/api/resource/v1/IntegrationsResource.java 66.66% <ø> (-5.56%) ⬇️
...io/kaoto/backend/api/resource/v1/StepResource.java 78.84% <ø> (ø)
...ackend/api/resource/v1/ViewDefinitionResource.java 45.45% <ø> (ø)
.../backend/api/resource/v2/IntegrationsResource.java 74.50% <ø> (ø)
...kend/api/service/deployment/DeploymentService.java 50.00% <ø> (ø)
.../backend/api/service/language/LanguageService.java 84.37% <ø> (ø)
...io/kaoto/backend/api/service/step/StepService.java 100.00% <ø> (ø)
.../service/viewdefinition/ViewDefinitionService.java 100.00% <ø> (ø)
...ion/parser/GenericViewDefinitionParserService.java 84.21% <ø> (ø)
... and 26 more

... and 1 file with indirect coverage changes

@mkralik3 mkralik3 linked an issue Jun 13, 2023 that may be closed by this pull request
@mkralik3 mkralik3 force-pushed the quarkus3_upgrade branch 25 times, most recently from eb7bd9a to 1f12476 Compare June 16, 2023 11:30
apupier and others added 10 commits June 21, 2023 12:04
Quarkus Universe bom is deprecated
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1#quarkus-universe-bom-is-deprecated

the update is required to use the tooling to do the migration between
Quarkus 2 and Quarkus 3

part of kaoto-archive#644

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
part of kaoto-archive#644

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
used `quarkus update --stream=3.0`
the upgrade is coming from Quarkus 3 bom upgrade

part of kaoto-archive#644

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
It causes a problem on Windows workflows
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkralik3 mkralik3 marked this pull request as ready for review June 21, 2023 11:17
@mkralik3 mkralik3 requested a review from a team June 21, 2023 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Quarkus 3 [BUG] Native test on Windows failing often on main
3 participants