Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: Integration/Kamelet/KameletBinding: Put name and description in FlowsWrapper.metadata #761

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

igarashitm
Copy link
Contributor

Fixes: #751

@igarashitm igarashitm requested a review from a team July 11, 2023 01:52
@igarashitm igarashitm changed the title fix: Kamelet name and description support under template fix: Integration/Kamelet/KameletBinding: Put name and description in FlowsWrapper.metadata Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #761 (043937e) into main (bc60efd) will increase coverage by 0.25%.
The diff coverage is 80.99%.

@@             Coverage Diff              @@
##               main     #761      +/-   ##
============================================
+ Coverage     78.75%   79.01%   +0.25%     
- Complexity      159      160       +1     
============================================
  Files            54       54              
  Lines          2980     3059      +79     
  Branches        506      534      +28     
============================================
+ Hits           2347     2417      +70     
+ Misses          421      420       -1     
- Partials        212      222      +10     
Impacted Files Coverage Δ
...arser/camelroute/IntegrationStepParserService.java 74.75% <57.14%> (+2.91%) ⬆️
...src/main/java/io/kaoto/backend/KamelPopulator.java 88.66% <72.97%> (-1.40%) ⬇️
...elet/KameletBindingDeploymentGeneratorService.java 68.80% <78.57%> (-1.94%) ⬇️
...ployment/generator/kamelet/KameletRepresenter.java 81.87% <83.33%> (+0.06%) ⬆️
.../step/parser/kamelet/KameletStepParserService.java 68.00% <87.50%> (+1.47%) ⬆️
...arser/kamelet/KameletBindingStepParserService.java 65.80% <100.00%> (+1.86%) ⬆️

... and 2 files with indirect coverage changes

@lordrip
Copy link
Contributor

lordrip commented Jul 11, 2023

What do you think of adding a default name when creating a new FlowsWraper? is this a good idea?

@Delawen Delawen merged commit 9023f0d into kaoto-archive:main Jul 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.5% 1.5% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kamelet name and description support under template
3 participants