Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: bindingMode: off is converted to bindingMode: false #864

Merged
merged 1 commit into from
Sep 16, 2023
Merged

fix: bindingMode: off is converted to bindingMode: false #864

merged 1 commit into from
Sep 16, 2023

Conversation

igarashitm
Copy link
Contributor

@igarashitm igarashitm commented Sep 15, 2023

Fixes: #863

YAML 1.1 defines off to be a boolean false
https://yaml.org/type/bool.html

Adding a workaround to restore off as a string with a quote.

Screenshot from 2023-09-15 14-22-06

After Sync
Screenshot from 2023-09-15 14-22-14

@igarashitm igarashitm requested a review from a team September 15, 2023 17:39
@igarashitm igarashitm enabled auto-merge (squash) September 15, 2023 17:40
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c655928) 70.68% compared to head (122adf9) 70.68%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #864   +/-   ##
=========================================
  Coverage     70.68%   70.68%           
  Complexity      199      199           
=========================================
  Files            69       69           
  Lines          3364     3364           
  Branches        565      565           
=========================================
  Hits           2378     2378           
  Misses          766      766           
  Partials        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igarashitm igarashitm merged commit 5c4a4d7 into kaoto-archive:main Sep 16, 2023
17 of 18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] bindingMode: off is converted to bindingMode: false
2 participants