This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(stepDetail): close step detail panel if unable to locate step #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 57.32% 57.20% -0.12%
==========================================
Files 68 68
Lines 2048 2054 +6
Branches 466 467 +1
==========================================
+ Hits 1174 1175 +1
- Misses 830 836 +6
+ Partials 44 43 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
igarashitm
previously approved these changes
Mar 23, 2023
lordrip
reviewed
Mar 23, 2023
lordrip
previously approved these changes
Mar 23, 2023
Co-authored-by: Ricardo M. <lordrip@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
lordrip
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1475 and #1371, where the updated step does not have the same
UUIDand then the open step detail view is incorrect. Now, if a step with the sameUUIDis not found, the step detail panel will close.NOTE: This fixes the reported bugs, but the user experience is not ideal. We have discussed using the previously selected step's path to automatically select the new step in that position, or to try to search for the previous step, however, without persisted unique identifiers we are not able to consistently predict where the previous step will be and this could be perceived as a bug rather than a feature. #609 might be able to address this in the future, or we can consider some of the other workarounds discussed in #1475.
Changes
integrationJson, close the step detail panel and reset the selected step if a step with a matchingUUIDis not foundNot sure what is happening with the code formatting again. 🤔