This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(StepsService): Generate steady IDs for steps and branches #1578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the moment, when a step is no longer available because it was removed, or its id changed, we close the step's detail panel since is no longer editing the right step.
This causes an issue with
vscode
since there's a circular dependency between the integration JSON and the code editor. Long story short, whenever there's an update of the integration JSON, the steps or branch IDs change, forcing a new sync cycle from thekogito
integration side.A partial fix to this issue is to ensure that the IDs are consistent between syncs, so this way the comparison inside of the KogitoEditorIntegrationProvider.tsx works.
Changes
getRandomArbitraryNumber()
to calculate IDsConsidering the following YAML file
the IDs would be:
fix: #1553
related to: #1475 (comment)