Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to build system #1038

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Changes to build system #1038

merged 1 commit into from
Sep 15, 2023

Conversation

ademariag
Copy link
Contributor

@ademariag ademariag commented Sep 10, 2023 •
edited
Loading

Fixes issue with build process

Proposed Changes

  • improvement: move most build related things under one workflow to make it easier establish dependencies
  • improvement: use cache from gha
  • improvement: change docker image to benefit from caching
  • improvement: change python tests to benefit from caching
  • improvement: run docker tests for both platforms
  • improvement: use docker/metadata-action@v4 to generate tags :branch :latest :tagname (0.32.1-ademaria-test)
  • improvement: only published non-release version from master and test/* branches
  • fix: reduce number of duplicated workflow runs
  • fix: only publishes if mandatory steps are successful
  • fix: runs tests on correct branch/docker images

@ademariag ademariag changed the title All proposed changes for visibility All proposed build related changes for visibility Sep 10, 2023
@ademariag ademariag marked this pull request as ready for review September 15, 2023 07:47
@ademariag ademariag changed the title All proposed build related changes for visibility Changes to build system Sep 15, 2023
@ademariag ademariag merged commit 50a4596 into kapicorp:master Sep 15, 2023
@ademariag ademariag deleted the all-build-changes branch September 15, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro ramaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademariag @ramaro