Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-actions): only publish when name is given #1065

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

MatteoVoges
Copy link
Contributor

@MatteoVoges MatteoVoges commented Oct 2, 2023

Proposed Changes

  • Fixes the following issue:
    On default-branches (or test/*) on forks with no docker-username, the docker buildx command fails, because no name is given and the images are named /kapitan[...], which is not allowed and throws invalid reference format. Now if no name is given, the command will be skipped.

Action run on nexenio-fork for reference

@MatteoVoges MatteoVoges added the github issue/feature regarding github (tests, issue templates) label Oct 2, 2023
@MatteoVoges MatteoVoges requested a review from ademariag October 2, 2023 11:31
@MatteoVoges MatteoVoges force-pushed the chore/fix-docker-publish branch from fcfaaba to 5df7a10 Compare October 2, 2023 11:34
@ademariag ademariag merged commit 2d1606f into master Oct 2, 2023
@ademariag ademariag deleted the chore/fix-docker-publish branch October 2, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github issue/feature regarding github (tests, issue templates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants