Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: bump int128/docker-manifest-create-action from 1 to 2" #1124

Conversation

MatteoVoges
Copy link
Contributor

Reverts #1107

v2 does not support suffixes anymore and goes with a new sources approach, where you would define the links to the image via digest. Wit hour current matrix strategy its hard to retrieve the digest per image / per platform. So let's rollback for now!

Guide to migrate by action owner:

Migration from V1 to V2

This action no longer supports the suffixes input.
You need to set an image URI with a digest or tag.
If you use docker/build-push-action, you can construct an image URI from the outputs as follows:

- uses: docker/build-push-action@v5
  id: build-amd64
  with: # ...omit...
- uses: docker/build-push-action@v5
  id: build-arm64
  with: # ...omit...

- uses: int128/docker-manifest-create-action@v2
  with:
    tags: ghcr.io/${{ github.repository }}:main
    sources: |
      ghcr.io/${{ github.repository }}@${{ steps.build-amd64.outputs.digest }}
      ghcr.io/${{ github.repository }}@${{ steps.build-arm64.outputs.digest }}

@MatteoVoges MatteoVoges added the github issue/feature regarding github (tests, issue templates) label Jan 26, 2024
@MatteoVoges MatteoVoges requested a review from ademariag January 26, 2024 10:39
@MatteoVoges MatteoVoges self-assigned this Jan 26, 2024
@MatteoVoges
Copy link
Contributor Author

CI depends on #1125

@ademariag ademariag enabled auto-merge January 26, 2024 19:25
@ademariag ademariag merged commit fab9ec1 into master Jan 26, 2024
7 checks passed
@ademariag ademariag deleted the revert-1107-dependabot/github_actions/int128/docker-manifest-create-action-2 branch January 26, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github issue/feature regarding github (tests, issue templates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants