Install reclass as module #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademariag
force-pushed
the
test/reclass-as-pip
branch
2 times, most recently
from
5418f40 to
495d6d2
Compare
ademariag
force-pushed
the
test/reclass-as-pip
branch
from
495d6d2 to
b7bd490
Compare
|
@ademariag Could you add the tests for submodules back again? Maybe we have to find a lightweight test-repo with submodules, that we can download. But just because the tests fail with kapitan, because we removed |
|
Why do we need to test the submodule capability? It made sense when reclass was sourced that way. Is there a real use case for it? |
It was a feature and is documented. See #914 #987 and https://kapitan.dev/pages/external_dependencies/?h=submodule#defining-dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Docs and Tests