Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not needed command #58

Merged
merged 1 commit into from
Apr 4, 2018
Merged

remove not needed command #58

merged 1 commit into from
Apr 4, 2018

Conversation

utf18
Copy link
Contributor

@utf18 utf18 commented Apr 4, 2018

updating the package cache is IMHO not needed since the

--no-cache

option will pull directly from the online repos anyway.
(with the small benefit of around 1MB for the package cache)

if you do this to avoid caching of the layers while building i suggest to build with the --no-cache option from docker:
docker build --no-cache

All the best

@utf18 utf18 mentioned this pull request Apr 4, 2018
@adrianchifor
Copy link
Member

adrianchifor commented Apr 4, 2018

--no-cache has nothing to do with --update. Adding --update is the equivalent of running apk update, which is recommended before installing packages.

Just double checked online, you're right.

@adrianchifor adrianchifor self-requested a review April 4, 2018 13:59
@utf18
Copy link
Contributor Author

utf18 commented Apr 4, 2018

update just updates the local package cache i suppose
screen shot 2018-04-04 at 15 59 18

@adrianchifor
Copy link
Member

Yes you're right, got confused for a second :) Thanks for the contribution!

@adrianchifor adrianchifor merged commit 96cba9f into kapicorp:master Apr 4, 2018
@utf18
Copy link
Contributor Author

utf18 commented Apr 4, 2018

you're welcome :)
sry for not be clear enough while proposing the change

@utf18 utf18 deleted the work branch April 4, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants