Let the logger format the message lazily. #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using format for logger is discouraged as it forces the message to format the message even when log are disabled.
|
Thank you for yet another contribution @Jean-Daniel . Join our slack channel on kubernetes slack (https://slack.k8s.io/) if you can! |
ramaro
reviewed
Mar 4, 2021
ramaro
requested changes
Mar 4, 2021
There was a problem hiding this comment.
Looks good, thanks @Jean-Daniel - just one tiny comment to change.
ramaro
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
format()for logger is discouraged as it forces the message to format the message even when log are disabled.Moreover, the
.formatvs%sis used inconsistently all over the codebase.Switching all usages to the logger builtin formatting make the code more consistent.
Proposed Changes
format()to format logging message to use the builtin logging formatter instead.