Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gojsonnet #753

Merged
merged 8 commits into from
Aug 1, 2021
Merged

Gojsonnet #753

merged 8 commits into from
Aug 1, 2021

Conversation

janeklb
Copy link
Contributor

@janeklb janeklb commented Jul 11, 2021

This is just a copy of #728, rebased from master's HEAD.

Creating a new PR just to see if tests pass in travis-ci

@janeklb janeklb mentioned this pull request Jul 11, 2021
@janeklb
Copy link
Contributor Author

janeklb commented Jul 11, 2021

🤔 travis-ci integration seems to be broken -- last few PRs haven't triggered builds either

@ramaro
Copy link
Member

ramaro commented Jul 12, 2021

@janeklb thanks for this. Yes, travis is broken at the moment and we're aware and working on it and will get back to you soon.

Copy link
Contributor

@pvanderlinden pvanderlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janeklb I added a comment to fix a mistake I made in the original PR.

kapitan/targets.py Outdated Show resolved Hide resolved
@ramaro
Copy link
Member

ramaro commented Aug 1, 2021

@janeklb @pvanderlinden thanks both! LGTM, merging.

@ramaro ramaro merged commit ea2cfc2 into kapicorp:master Aug 1, 2021
@janeklb janeklb deleted the gojsonnet branch August 16, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants