improve jinja2 templating error report for TemplateError #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2.TemplateError does not include the template line number which can be of great help when troubleshooting errors like 'foo' has no attribute 'bar' The line number can however be inferred from the stack trace. This was inspired by https://github.com/saltstack/salt/blob/master/salt/utils/templates.py Example output: Jsonnet error: failed to compile test/main.jsonnet: RUNTIME ERROR: Jsonnet jinja2 failed to render templates/abc.j2: Jinja2 TemplateError: 'foo' has no attribute 'bar', at templates/abc.j2:240 Signed-off-by: David Verbeiren <david.verbeiren@tessares.net>
|
Thank you @dverbeir ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jinja2.TemplateError does not include the template line number which can be of great help when troubleshooting errors like
'foo' has no attribute 'bar'
The line number can however be inferred from the stack trace. This was inspired by
https://github.com/saltstack/salt/blob/master/salt/utils/templates.py
Example output:
Jsonnet error: failed to compile test/main.jsonnet:
RUNTIME ERROR: Jsonnet jinja2 failed to render templates/abc.j2: Jinja2 TemplateError: 'foo' has no attribute 'bar', at templates/abc.j2:240