Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix m to msg #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

bug fix m to msg #11

wants to merge 5 commits into from

Conversation

DougAnderson444
Copy link
Contributor

Fixs #9

@DougAnderson444
Copy link
Contributor Author

Tests are passing now. There seemed to be an issue with the count. When 2010 is added to the multifeed, it's not in the tail so that callback never gets triggered, so the count is one less than was recorded.

The reason it was passing before was the m.seq === m.seq bug made seq always true (even when it was false), which means the callback always fired, even though the insert didn't update the tail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougAnderson444