feat: implement getDeviceByUID method #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdremy
commented
Jan 16, 2023
| @@ -91,7 +91,7 @@ export const getDevice: { | |||
| const device = await getDevice(73); | |||
| ``` | |||
| */ | |||
| (): Promise<Device>; | |||
| (deviceId: number): Promise<Device>; | |||
There was a problem hiding this comment.
typescript definition fix, not related to the main purpose of this PR, sorry.
lbdremy
commented
Jan 16, 2023
| @@ -265,7 +306,7 @@ final class SetVolumeCommand: Command { | |||
| @Param var volume: Double | |||
|
|
|||
| func execute() throws { | |||
| var device = try getDevice(deviceId: deviceId) | |||
| let device = try getDevice(deviceId: deviceId) | |||
There was a problem hiding this comment.
small fix for warning during compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR includes a new method getDeviceByUID which does exactly that ^^ get a device using its UID instead of id, it can be useful as the UID is known ahead of creation of the device, as well that the only way to find an hidden device (as explained here https://gist.github.com/kdepp/46c812b05cda6e44a292328b31d0784c#file-audiohardwarebase-h-L696-L700).
That's my first time I'm writing some Swift so it works but it is probably not optimal, feedbacks really welcome.
Thanks for your time