Fixes some rss feed validation issues

karamdeep-singh · Mar 15, 2012 · eded7c5 · eded7c5
1 parent d8a9eff
commit eded7c5
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/external/feedcreator.class.php b/external/feedcreator.class.php
@@ -904,6 +904,7 @@ function createFeed() {
         $feed.= '    xmlns:sy="http://purl.org/rss/1.0/modules/syndication/"'."\n";
         $feed.= '    xmlns:slash="http://purl.org/rss/1.0/modules/slash/"'."\n";
 		$feed.= ">\n";
+        $feed.= '    <atom:link href="'.$this->syndicationURL.'" rel="self" type="application/rss+xml" />'."\n";
 		$feed.= "    <channel>\n";
 		$feed.= "        <title>".FeedCreator::iTrunc(htmlspecialchars($this->title),100)."</title>\n";
 		$this->descriptionTruncSize = 500;

diff --git a/framework/core/controllers/expController.php b/framework/core/controllers/expController.php
@@ -584,6 +584,7 @@ function getRSSContent() {
             $rss_item->description = expString::convertSmartQuotes($item->body);
             $rss_item->date = isset($item->publish_date) ? date('r',$item->publish_date) : date('r', $item->created_at);
             $rss_item->link = makeLink(array('controller'=>$this->classname, 'action'=>'show', 'title'=>$item->sef_url));
+            $rss_item->guid = expUnserialize($item->location_data)->src.'-id#'.$item->id;
             if (!empty($item->expCat[0]->title)) $rss_item->category = array($item->expCat[0]->title);
             $comment_count = expCommentController::findComments(array('content_id'=>$item->id,'content_type'=>$this->basemodel_name));
             if ($comment_count) {

diff --git a/framework/modules/blog/controllers/blogController.php b/framework/modules/blog/controllers/blogController.php
@@ -279,6 +279,7 @@ function getRSSContent() {
             $rss_item->description = expString::convertSmartQuotes($item->body);
             $rss_item->date = isset($item->publish_date) ? date('r',$item->publish_date) : date('r', $item->created_at);
             $rss_item->link = makeLink(array('controller'=>$this->classname, 'action'=>'show', 'title'=>$item->sef_url));
+            $rss_item->guid = expUnserialize($item->location_data)->src.'-id#'.$item->id;
             if (!empty($item->expCat[0]->title)) $rss_item->category = array($item->expCat[0]->title);
             $comment_count = expCommentController::findComments(array('content_id'=>$item->id,'content_type'=>$this->basemodel_name));
             if ($comment_count) {

diff --git a/framework/modules/filedownloads/controllers/filedownloadController.php b/framework/modules/filedownloads/controllers/filedownloadController.php
@@ -166,6 +166,7 @@ function getRSSContent() {
             $rss_item->description = expString::convertSmartQuotes($item->body);
             $rss_item->date = isset($item->publish_date) ? date('r',$item->publish_date) : date('r', $item->created_at);
             $rss_item->link = makeLink(array('controller'=>$this->classname, 'action'=>'show', 'title'=>$item->sef_url));
+            $rss_item->guid = expUnserialize($item->location_data)->src.'-id#'.$item->id;
             if (!empty($item->expCat[0]->title)) $rss_item->category = array($item->expCat[0]->title);
 
             // Add the attachment/enclosure info

diff --git a/site_rss.php b/site_rss.php
@@ -41,13 +41,14 @@
 
 if ($site_rss->enable_rss == true) {
 	$rss = new UniversalFeedCreator();
+    $rss->encoding = LANG_CHARSET;
 	$rss->cssStyleSheet = "";
 //	$rss->useCached("PODCAST");
 	$rss->useCached();
 	$rss->title = $site_rss->feed_title;
 	$rss->description = $site_rss->feed_desc;
     $rss->image->url = URL_FULL.'themes/'.DISPLAY_THEME.'/images/logo.png';
-    $rss->image->title = ORGANIZATION_NAME;
+    $rss->image->title = $site_rss->feed_title;
     $rss->image->link = URL_FULL;
 //    $rss->image->width = 64;
 //    $rss->image->height = 64;