Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to assign the reference lyric in the right side section. #1488

Closed
andy840119 opened this issue Jul 29, 2022 · 4 comments
Closed

Able to assign the reference lyric in the right side section. #1488

andy840119 opened this issue Jul 29, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

image

Instead of clicking the badge, it might be better just let user able to adjust and see the property in the right side. Maybe follow the naming like the note section?

Section name and the field in the section:

  • Reference lyric
    • Area to select the reference lyric, will show the popover or trigger the selection(should implement the single select mode) after click the select button. Also will have the delete button(or un-link chain icon) at the right-side of the select button.
  • Properties (will show this section after contains the reference lyric)
@andy840119 andy840119 added the enhancement New feature or request label Jul 29, 2022
@andy840119
Copy link
Member Author

andy840119 commented Jul 29, 2022

Not really sure should make the sub-edit mode in the reference lyric mode?
Because it might be hard to define a default mode(sync or reference) after user mark the reference lyric.

If the user wants to change the sync mode, they can just switch to the edit mode, then click the reference lyric to "take the control" back.

@andy840119
Copy link
Member Author

andy840119 commented Jul 29, 2022

image

Another concept(sorry for my bad drawing) is:

  • make the each mode as the selection
  • all the property are in the selection
  • if user click the switch button in the selection, means user want to user that mode.

cons:

  • not follow the current UX behavior, means it might be broken in the future.

@andy840119
Copy link
Member Author

andy840119 commented Jul 29, 2022

Another concept(might be the final):
Will be able to show the reference mode or sync mode in the lyric selection popover.
We can simply use the reference lyric detect to detect all the lyric in the popover.

If the lyric is not detectable, means it's time to user the reference mode.

But user still able to change the mode.

@andy840119 andy840119 changed the title Able to assign the reference lyric in the right side seciton. Able to assign the reference lyric in the right side section. Aug 21, 2022
@andy840119
Copy link
Member Author

Guess it should be OK to close.

@andy840119 andy840119 added this to the 2022.0827 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant