Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lyric can reference by other lyric. #1444

Closed
andy840119 opened this issue Jul 16, 2022 · 8 comments
Closed

Implement lyric can reference by other lyric. #1444

andy840119 opened this issue Jul 16, 2022 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

andy840119 commented Jul 16, 2022

For some cases, some of the lyric in the karaoke song are almost same as other lyrics, the difference between those lyrics are the offset time.
So we can add property like ReferenceLyric to mark the lyric is referenced by other lyrics.

Also, because some of the property is not need to be referenced, so we can make the enums to decide which properties should be referenced:

  • Lyric (will sync the lyric text, ruby and romaji from the referenced lyric)
    • TimeTag (will sync the time-tag also)
  • Start time and end time(?)
  • Singer
  • Translate
  • Language

Another concept:

  1. Sync property (assign the offset time is needed)
    • Allow customized singers (or called Sync the singers with default true)
    • Allow customized time-tags (or called Sync the time-tags with default true)
  2. Reference rhythm (maybe will show referenced lyric's time-tag in the record or modify mode).
@andy840119 andy840119 changed the title Implement referenc lyric Implement lyric can reference by other lyric. Jul 16, 2022
@andy840119
Copy link
Member Author

And not really sure will it be a good feature to compare the property between lyric and the referenced lyric.
Like the time-tag.

@andy840119
Copy link
Member Author

Also, will implemented in the manage lyric mode.
Might create a new section in that mode.

@andy840119
Copy link
Member Author

And might be auto add the reference lyric if trying to copy the lyric.

@andy840119
Copy link
Member Author

andy840119 commented Jul 23, 2022

Here's the example:
(n) menas it's the n unique lyric
[n] means it's the n lyric that contains the same time-tag (or rhythm).

ただ風に揺られて (0) [0]
何も考えずに (1) [1]
ただ雲を眺めて (2) [0]
過ごすのもいいよね (3) [1]

誰しも何かしら (4) [0]
使命を抱えてる (5) [1]
ただそれだけのこと (6) [0]
悩むのはもうやめた (7) [1]

さざなみの音に癒やされてく(8) [2]
軌跡を運ぶ風の音 (9) [3]
時を閉じ込めて (10) [4]

シャイニングスター綴れば (11) [5]
夢に眠る幻が掌に降り注ぐ (12) [6]
新たな世界へ (13) [7]
I'll believe of my sensation (14) [5]
果てしない道の向こうで (15) [6]
瞼の裏に映る (16) [6]
一滴の光 (17) [8]
トキメキを感じて (18) [9]

貴方が触れる全て (19) [0]
幸せであるように (20) [1]
今生きる喜びを (21) [0]
忘れてしまわないよう (22) [1]

月の光 隠す雲は揺らぎ(23) [2]
自由の翼は今も(24) [3]
大空を翔る(25) [4]

シャイニングスター綴れば (11) [5]
無限のイマジネーション (26) [6]
魔法が使えるような (27) [6]
世界が広がる (28) [7]
I'll believe of my sensation (14) [5]
今も降り募る想いよ  (29) [6]
切なさやトキメキが (30) [6]
心の真ん中で (31) [8]
熱いメロディになる (32) [9]

シャイニングスター綴れば  (11) [5]
無限のイマジネーション (26) [6]
魔法が使えるような (27) [6]
世界が広がる (28) [7]
I'll believe of my sensation (14) [5]
今も降り募る想いよ (29) [6]
切なさやトキメキが (33) [6]
輝き出す (34) [10]

シャイニングスター綴れば (11) [5]
夢に眠る幻が掌に降り注ぐ (12) [6]
新たな世界へ (13) [7]
I'll believe of my sensation (14) [5]
果てしない道の向こうで (15) [6]
瞼の裏に映る (16) [6]
一滴の光 (17) [8]
トキメキを感じて (18) [9]

LaLaLa

As the demo shows, there are total 51 lyrics.
But only has 34 unique lyrics.
And only contains 10 different time-tag combination, most of them are duplicated or very similar.

Source:
https://www.youtube.com/watch?v=Qd01-6xVSHk

@andy840119
Copy link
Member Author

andy840119 commented Jul 24, 2022

然後針對不同的mode或許可以定義目前 lyric is writeable?
Or make the utils that check lyric property is writeable by edit mode?

@andy840119
Copy link
Member Author

Another way is to write the sync and binding inside the lyric.
And not save those binding property into json.

@andy840119
Copy link
Member Author

andy840119 commented Aug 29, 2022

The remaining part of this issue:

  • Should block the change in the UI to prevent letting user to edit the referenced lyric.
  • Should have cool UI to let user able to know the lyric is reference/sync from other lyric in "every" mode.
  • Click around and find the bugs.

@andy840119
Copy link
Member Author

Guess can close this issue because remaining part can be handle in the #1563.

@andy840119 andy840119 added this to the 2022.0924 milestone Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant