New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reference lyric strategy class. #1523

Merged

andy840119 merged 3 commits into karaoke-dev:master from andy840119:implement-reference-lyric-strategy-class

Aug 21, 2022

Member

andy840119 commented Aug 21, 2022

Implement part of #1444

What's done in this PR:

Implement the config model.
Implement the convertor for convert the config class into the json.

andy840119 added 3 commits

August 21, 2022 21:44


          define the config model for save the sync strategy.

4f4f20d


          Implement the convertor for able to save/load the config into the json.

72f4675


          Add into the convertor list.

ae5e5a9

andy840119 added the enhancement label

andy840119 added this to the 2022.0827 milestone

pull-request-size bot added the size/L label

andy840119 merged commit f2371a7 into karaoke-dev:master

andy840119 deleted the implement-reference-lyric-strategy-class branch

August 21, 2022 14:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement size/L