Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think how to sync the note property from the reference lyric? #1543

Open
andy840119 opened this issue Aug 31, 2022 · 2 comments
Open

Think how to sync the note property from the reference lyric? #1543

andy840119 opened this issue Aug 31, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@andy840119
Copy link
Member

Part of #1444
The reason of issue #1541

What should be done in this issue:
Think a way about how to sync the notes from the referenced lyric, means if referenced lyric change it's note (maybe create/ or delete or press sync button) will sync the change to the lyric.
Think a way about how to sync the property in the notes between the notes from referenced lyric and reference lyric.

@andy840119 andy840119 added the enhancement New feature or request label Aug 31, 2022
@andy840119
Copy link
Member Author

https://miro.com/app/board/uXjVPbYAMZY=/

image
Solution 1:

  • Should sync the note number and order if user create or delete the notes belongs to the referenced lyric by the NotesChangeHandler.
  • Should give the notes a reference note property. If the note is referenced by another note, means it will get the config from the reference lyric to determine should sync which property from the referenced note.

And note that this solution does not required structure change in the #1541

@andy840119
Copy link
Member Author

andy840119 commented Aug 31, 2022

Nice mira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant