New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make note become nested object of lyric.cs #1541

Closed

andy840119 opened this issue Aug 30, 2022 · 4 comments

Labels

Member

andy840119 commented Aug 30, 2022

Part of #1444
Figure out this issue while implementing #1540

Sync referenced lyric should also sync from the lyric.
So should be better to move the note into nested object for easier to sync.

andy840119 added the enhancement label

andy840119 mentioned this issue

Create enum for let user easier to decide the sync property? #1542

Open

Member Author

andy840119 commented Aug 30, 2022

Not really sure will editor able to select the nested object?

Member Author

andy840119 commented Aug 30, 2022

And maybe see how editor did with the slider?

andy840119 mentioned this issue

Think how to sync the note property from the reference lyric? #1543

Open

Member Author

andy840119 commented Aug 31, 2022

This solution is not better than #1543 (comment)
Should not place everything inside notes.

Member Author

andy840119 commented Aug 31, 2022

Guess should be better to close this issue because it might not follow the structure how lazer wants.

andy840119 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment