Issue-1175 null error message handling in Result failure #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nishant-sehgal build failed so can you re-confirm |
|
Yes checking. But test case ran fine in my local.Checking further |
Nishant-sehgal
force-pushed
the
develop
branch
from
c02f2cf
to
2c61828
Compare
|
@ptrthomas i took latest and pushed again build is failing.But in local it is passing not sure what is happening. Any pointers?
|
|
no idea. maybe this exception is different across OS / JDK version - so maybe it is safe to keep it as it is: https://travis-ci.org/github/intuit/karate/builds/734888650#L1251 |
Nishant-sehgal
force-pushed
the
develop
branch
2 times, most recently
from
9b22c40
to
a134130
Compare
Nishant-sehgal
force-pushed
the
develop
branch
from
a134130
to
62c779b
Compare
|
@ptrthomas Working as expected now.Please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"null" error message handling when Java regex method internally throws StackOverflow.
if StackOverflowError is thrown it does not have error message set in it so we see [ERROR] FooRunner.testUsers foo.feature:4 - null.
Adding error as it is if error.getMessage() is null