Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1561 - Fixed a bug where we might override the existing path in a supplied url. #1625

Merged
merged 1 commit into from
May 28, 2021

Conversation

aaronjwhiteside
Copy link
Contributor

Description

Fixed a bug where we might override the existing path in a supplied url.

@aaronjwhiteside
Copy link
Contributor Author

aaronjwhiteside commented May 28, 2021

@ptrthomas

Build error looks to be unrelated to my change:

Error:  Failures: 
Error:    DockerRunner.testMock:29 match failed: CONTAINS
  $ | actual does not contain expected (STRING:STRING)
  'about:blank'
  '11_tab'

src/test/java/driver/11.feature:11
src/test/java/driver/00.feature:40 ==> expected: <0> but was: <1>

And for what it's worth, the build passes for me locally:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for karate-parent 2.0.0:
[INFO] 
[INFO] karate-parent ...................................... SUCCESS [  0.514 s]
[INFO] karate-core ........................................ SUCCESS [ 20.276 s]
[INFO] karate-junit4 ...................................... SUCCESS [  8.560 s]
[INFO] karate-junit5 ...................................... SUCCESS [  3.664 s]
[INFO] karate-demo ........................................ SUCCESS [ 38.654 s]
[INFO] karate-gatling ..................................... SUCCESS [ 31.275 s]
[INFO] karate-mock-servlet ................................ SUCCESS [ 11.156 s]
[INFO] karate-robot ....................................... SUCCESS [  2.900 s]
[INFO] karate-e2e-tests ................................... SUCCESS [  0.129 s]
[INFO] karate-archetype ................................... SUCCESS [  0.134 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:57 min
[INFO] Finished at: 2021-05-28T16:37:03+10:00
[INFO] ------------------------------------------------------------------------

@ptrthomas ptrthomas merged commit ba93d38 into karatelabs:develop May 28, 2021
@ptrthomas
Copy link
Member

@aaronjwhiteside no worries, yes the CI fail is a ui test that's flaky, I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants