Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description.
A.- Board: TTGO-T-DISPLAY. Sw version: git as of Feb. 26th 2021.
B.- Use case: to control stations +/- with on-board buttons S1 & S2 (i.e., pins GPIO00 & GPIO35 configured as inputs with GPIO_PULLUP_ENABLE).
C.- Modified ttgotdisplay.csv and flashed:
D.- Result: Button S2 (GPIO35) moves to next station in the list, as expected. Button S1 (GPIO00) is not responsive (GPIO00 is never configured).
E.- Proposed solution. Tested and working:
1.- Changes in file ClickButtons.c (see below).
2.- Changes in file gpio.c (see below).
Thanks, and keep up the good work.
(And remember when using GPIO00 in your application: it is better to use esptool.py, other tools might mess around with RTS&DTR signals).