Explicit iOS Support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This is required for app store submission. Add additional iOS architectures to supported list.
kareman
reviewed
Nov 16, 2017
| <key>CFBundleSignature</key> | ||
| <string>????</string> | ||
| <key>CFBundleVersion</key> | ||
| <string>400</string> |
There was a problem hiding this comment.
Is there any significance to the number 400, or can it be any number?
There was a problem hiding this comment.
No technical significance. I picked a number large enough to hopefully not be smaller than build numbers in use already, but I went for 400 because the current version is 0.40. Not a strong reason.
|
Thank you, I hope it can be useful for others using this project in iOS apps too. I will tag a new release as soon as I get rid of those warnings in Xcode. |
kareman
added a commit
that referenced
this pull request
Nov 17, 2017
Readme: add banjun/NorthLayout to examples, shorten podspec instructions Explicit iOS Support (#14) … * Explicitly support iOS back to version 10.3 (arbitrary one version back rule) * Set build number explicitly to ensure it is set for Carthage builds. This is required for app store submission. Add additional iOS architectures to supported list. Remove uses of CharacterView. String is a collection again. … * Silences Xcode 9.1 warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building against an iOS target, the default is to only support the most recent version of iOS, but there is no reason why FootlessParser cannot support previous versions of iOS.
This PR arbitrarily supports back to version 10.3 of iOS and sets the bundle version to a hardcoded value because otherwise building as a dependency through Carthage can result in an invalid bundle version when submitting to the iOS App Store.