Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rmitsch
Copy link

@rmitsch rmitsch commented Nov 21, 2022

Resolves #1.

This fixes the build on Windows by including the SQLite source code and considering it in setup.py. Vendoring SQLite might not be the best option here - downloading from https://sqlite.org/download.html might be more reasonable - but I think it's probably fine for now.

A CI with a smoke test would probably a good idea, I'd include that in a separate PR though.

@karlb
Copy link
Owner

karlb commented Apr 18, 2024

Sorry for the late reply.

I don't understand how this works and why this is necessary.

  • Don't the Windows compilation instructions on https://www.sqlite.org/loadext.html apply for spellfix?
  • Do you have any explanation or link on why the normal approach doesn't work and why your approach solves the issue?
  • I see that sqlite/windows.c is included when building on Windows, but I don't see how any of the other added files are ever used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling on Windows 10
2 participants