Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying env #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow specifying env #104

wants to merge 1 commit into from

Commits on Oct 23, 2015

  1. Allow specifying env 

    The original code here:

```
        env = options['environment'] ? :production : options['environment'].to_s.to_sym
```

Looks backwards, as it will force env to always be production. Since you are defaulting the environment to production in the Thor args

```
      class_option :environment,
                 aliases: '-e',
                 default: ENV['MM_ENV'] || ENV['RACK_ENV'] || 'production',
```

you can simplify this.
    @johnnyshields
    johnnyshields committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    e4c7ca1 View commit details
    Browse the repository at this point in the history